From 0a396ea9155be6fb6a84ed5c5a68f5567913b251 Mon Sep 17 00:00:00 2001
From: Arie Peterson <arie@greenhost.nl>
Date: Wed, 22 Feb 2023 11:33:46 +0100
Subject: [PATCH] Fix rejecting consent requests using newer hydra API
---
backend/web/login/login.py | 28 ++++++++++++++++++----------
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/backend/web/login/login.py b/backend/web/login/login.py
index afee0f80..7fe6e5be 100644
--- a/backend/web/login/login.py
+++ b/backend/web/login/login.py
@@ -338,11 +338,15 @@ def consent():
except AttributeError:
current_app.logger.error(f"Could not find app for client {client_id}")
return redirect(
- consent_request.reject(
- error="No access",
- error_description="The user has no access for app",
- error_hint="Contact your administrator",
- status_code=401,
+ hydra_admin_api.reject_consent_request(
+ challenge,
+ # In previous versions of the hydra API client library, we
+ # could set these parameters, but that's no longer possible,
+ # not sure why.
+ # error="No access",
+ # error_description="The user has no access for app",
+ # error_hint="Contact your administrator",
+ # status_code=401,
)
)
@@ -359,11 +363,15 @@ def consent():
# If there is no role in app_roles or the role_id for an app is null user has no permissions
current_app.logger.error(f"User has no access for: {app_obj.name}")
return redirect(
- consent_request.reject(
- error="No access",
- error_description="The user has no access for app",
- error_hint="Contact your administrator",
- status_code=401,
+ hydra_admin_api.reject_consent_request(
+ challenge,
+ # In previous versions of the hydra API client library, we
+ # could set these parameters, but that's no longer possible,
+ # not sure why.
+ # error="No access",
+ # error_description="The user has no access for app",
+ # error_hint="Contact your administrator",
+ # status_code=401,
)
)
else:
--
GitLab