From 20564110dc4675666000d102aeaa3de4c9d821d4 Mon Sep 17 00:00:00 2001
From: Mart van Santen <mart@greenhost.nl>
Date: Thu, 8 Jun 2023 15:08:33 +0800
Subject: [PATCH] Processed comments of review
---
frontend/src/components/UserModal/UserModal.tsx | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/frontend/src/components/UserModal/UserModal.tsx b/frontend/src/components/UserModal/UserModal.tsx
index 083a6630..6b29aa59 100644
--- a/frontend/src/components/UserModal/UserModal.tsx
+++ b/frontend/src/components/UserModal/UserModal.tsx
@@ -174,14 +174,13 @@ export const UserModal = ({ open, onClose, userId, setUserId }: UserModalProps)
if (obj) {
return obj;
}
- // Check if slug shows up in external list
+
let slug = item.name.toLowerCase();
// Strip ext from the slug, the ext prefix is advised in the documentation
// for external applications, however, we no not need it to match it with
// our application list
slug = slug.replace(/^ext-/, '');
- slug = slug.replace(/^ext/, '');
obj = _.find(appExternalAccessList, ['name', slug!]);
if (obj) {
return obj;
@@ -191,13 +190,13 @@ export const UserModal = ({ open, onClose, userId, setUserId }: UserModalProps)
return obj;
};
- // Return logo of app, if not found, return a generic default
+ // Return filepath of logo of the app, if such logo file is specified
const fetchAppImage = (item: any) => {
const obj = fetchAppObject(item);
return obj?.image;
};
- // Return name of app
+ // Return name/label of app
const fetchAppLabel = (item: any) => {
const obj = fetchAppObject(item);
if (obj?.label === '') {
--
GitLab