From f8fbde2880753ea4eefd7ea608178c71b33f14f8 Mon Sep 17 00:00:00 2001
From: Maarten de Waard <maarten@greenhost.nl>
Date: Fri, 23 Sep 2022 11:18:37 +0200
Subject: [PATCH] remove tar after unpacking, skip apps with no name

---
 templates/nextcloud-onlyoffice-config.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/templates/nextcloud-onlyoffice-config.yaml b/templates/nextcloud-onlyoffice-config.yaml
index e1b7666d..7ef74475 100644
--- a/templates/nextcloud-onlyoffice-config.yaml
+++ b/templates/nextcloud-onlyoffice-config.yaml
@@ -56,7 +56,9 @@ data:
 
     # Install all apps declared in the `apps` helm values array
     {{- range .Values.apps }}
-    {{- if and .github_repository .version }}
+    {{- if not .name }}
+      echo "Skipping app {{ . }} without name variable set"
+    {{- else if and .github_repository .version .release_filename }}
     # Apps with a pinned version number are downloaded from GitHub so we can
     # update the pin with Renovatebot
 
@@ -81,6 +83,7 @@ data:
       # Extract app into target directory. The app tars usually contain a folder
       # named after the app name
       tar -xf "{{ .name }}.tar.gz" -C "$target_directory"
+      rm "{{ .name }}.tar.gz"
     fi
     {{- else }}
     # Unpinned app
-- 
GitLab