From 474efecd0854e3cd269c1ede09488e690589c83c Mon Sep 17 00:00:00 2001
From: Mart van Santen <mart@greenhost.nl>
Date: Thu, 21 Oct 2021 16:14:49 +0200
Subject: [PATCH] Improved comment about password

---
 docs/local_dev_remote_kratos.md      | 36 ++++++++++------------------
 helmchart/single-sign-on/values.yaml |  4 +++-
 2 files changed, 16 insertions(+), 24 deletions(-)

diff --git a/docs/local_dev_remote_kratos.md b/docs/local_dev_remote_kratos.md
index 7681975..6715070 100644
--- a/docs/local_dev_remote_kratos.md
+++ b/docs/local_dev_remote_kratos.md
@@ -16,15 +16,16 @@ forwards during development.
 
 # Installation
 
-The current kratos version is not yet merged to master. However, this does not
-prevent us from developing already. To use / add the kratos backend, the
-following needs to be done:
+The current kratos version is not yet installed in the released versions of 
+Stackspin. However, this does not prevent us from developing already with
+kratos. To use / add the kratos backend, the following needs to be done:
 
 On your provisioning machine, make sure to checkout:
 
 `git@open.greenhost.net:openappstack/single-sign-on.git`
 
-Be sure to choose the kratos branch: `76-use-kratos-as-identity-manager`
+Be sure to check out the latest master. Or select a more modern brach if you
+want to test / install (optional) improvements of the kratos system. 
 
 Once this is all fetched, installation can be done with the following steps:
 
@@ -38,13 +39,19 @@ flux suspend source chart oas-single-sign-on
 ```
 
 2. Make a backup of the current keys and configuration values. We needs those
-when we install the new version of the `single-sign-on` helmchart:
+   when we install the new version of the `single-sign-on` helmchart:
 
 ```
 helm get values single-sign-on -n oas > /to/a/path/my_cluster_values.yaml
 ```
 
-3. Install the single-sign-on helmchart with kratos service
+3. Install all helm dependencies
+
+```
+helm dep update
+```
+
+4. Install the single-sign-on helmchart with kratos service
 
 ```
 cd helmchart/single-sign-on
@@ -53,23 +60,6 @@ helm upgrade -f /to/a/path/my_cluster_values.yaml single-sign-on . -n oas --debu
 
 This will install the latest version. 
 
-**Note**: Known issue, in some circumstances the installation fails because
-kratos automigration kicks in too early. This needs more investigation. If you run 
-into this problem, try the following: 
-
-1. Open the file `helmchart/single-sign-on/values.yaml`
-2. Set the `autoMigrate` on line 151 to `false`
-3. Rerun the upgrade.
-
-After successful upgrade, adjust the value back to `true` and rerun the upgrade
-once again. As the PVC and database server are now up and running, the
-automigration works as expected
-
-It looks there is some kind of race condition, by first disabling the
-automigration, the storage to store the database is created, so on the second run, 
-this race condition is not hit. This *should* not happen with kubernetes, so 
-maybe the cause is something else.
-
 # Development
 
 To develop, one needs access to kratos from the development system. A helper 
diff --git a/helmchart/single-sign-on/values.yaml b/helmchart/single-sign-on/values.yaml
index 2e8c683..95fc823 100644
--- a/helmchart/single-sign-on/values.yaml
+++ b/helmchart/single-sign-on/values.yaml
@@ -80,7 +80,9 @@ postgresql:
   postgresqlDatabase: kratos
   postgresqlUsername: kratos
   # This will be overwritten during installation. If this helm
-  # chart is installed manual, this should be randomized or altered
+  # chart is installed manual, this should be randomized or altered. If you
+  # change this, make sure the config part under kratos/kratos/config/dsn is in 
+  # sync with this entry
   postgresqlPassword: kratos
 
 kratos:
-- 
GitLab