From e48dc5d4cceb51e194ac2b9bf82198f2886562e1 Mon Sep 17 00:00:00 2001
From: Mark <mark@openappstack.net>
Date: Sat, 14 Dec 2019 13:32:42 +0100
Subject: [PATCH] Change quotes to disbale bash injection features

---
 .../single-sign-on/templates/job-create-admin-user.yaml     | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/helmchart/single-sign-on/templates/job-create-admin-user.yaml b/helmchart/single-sign-on/templates/job-create-admin-user.yaml
index 2ed7fbf..1982197 100644
--- a/helmchart/single-sign-on/templates/job-create-admin-user.yaml
+++ b/helmchart/single-sign-on/templates/job-create-admin-user.yaml
@@ -30,8 +30,8 @@ spec:
           value: {{ .Values.userbackend.email }}
         command: ["/bin/bash", "-c"]
         args:
-        - /bin/bash ./utils/create-user.bash $USERNAME "$PASSWORD" $EMAIL {{ include "single-sign-on.fullname" . }}-userbackend 80 &&
+        - /bin/bash ./utils/create-user.bash '$USERNAME' '$PASSWORD' '$EMAIL' {{ include "single-sign-on.fullname" . }}-userbackend 80 &&
           /bin/bash ./utils/create-role.bash admin {{ include "single-sign-on.fullname" . }}-userbackend 80 &&
           /bin/bash ./utils/create-application.bash user-panel {{ include "single-sign-on.fullname" . }}-userbackend 80 &&
-          /bin/bash ./utils/assign-role.bash $USERNAME admin {{ include "single-sign-on.fullname" . }}-userbackend 80 &&
-          /bin/bash ./utils/grant-access.bash $USERNAME user-panel {{ include "single-sign-on.fullname" . }}-userbackend 80
+          /bin/bash ./utils/assign-role.bash '$USERNAME' admin {{ include "single-sign-on.fullname" . }}-userbackend 80 &&
+          /bin/bash ./utils/grant-access.bash '$USERNAME' user-panel {{ include "single-sign-on.fullname" . }}-userbackend 80
-- 
GitLab