From c71cc029fd948cc17e3d27a7e4f6f52567aca44b Mon Sep 17 00:00:00 2001 From: Varac <varac@varac.net> Date: Thu, 25 Nov 2021 12:56:51 +0100 Subject: [PATCH] Apply suggestion to new app issue template --- .gitlab/issue_templates/new_app.md | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/.gitlab/issue_templates/new_app.md b/.gitlab/issue_templates/new_app.md index a9810ab34..6237067ba 100644 --- a/.gitlab/issue_templates/new_app.md +++ b/.gitlab/issue_templates/new_app.md @@ -5,16 +5,16 @@ * [ ] Create new source if needed in `flux2/infrastructure/sources/APP.yaml` * [ ] Include `APP.yaml` in `flux2/infrastructure/sources/kustomization.yaml` -* [ ] In case of a core app, add `helmRelease` and `deployment` dependencies - to `flux2/cluster/base/core.yaml` +* [ ] In case of a core app, add healthChecks to `core` `Kustomization` + (`flux2/cluster/base/core.yaml`) * [ ] Add app secret: `install/templates/stackspin-APP-variables.yaml.jinja` - * [ ] `flux2/cluster/optional/APP/APP.yaml` - * [ ] `flux2/apps/APP/kustomization.yaml` - * [ ] If needed, add PVCs in `flux2/apps/APP/pvc.yaml` - * [ ] Add `HelmRelease` in `flux2/apps/APP/release.yaml` - * Mem resource requests/limits: See https://open.greenhost.net/stackspin/stackspin/-/issues/1027 - * [ ] mem request: the median weekly memory usage of an app - * [ ] mem limit: 150% of the weekly max memory usage + * [ ] Flux kustomization: `flux2/cluster/optional/APP/APP.yaml` + * [ ] K8s kustomization: `flux2/apps/APP/kustomization.yaml` + * [ ] If needed, add PVCs in `flux2/apps/APP/pvc.yaml` + * [ ] Add `HelmRelease` in `flux2/apps/APP/release.yaml` + * Mem resource requests/limits: See https://open.greenhost.net/stackspin/stackspin/-/issues/1027 + * [ ] mem request: the median weekly memory usage of an app + * [ ] mem limit: 150% of the weekly max memory usage ### Single sign-on @@ -74,7 +74,8 @@ Add the following elements to `.gitlab-ci.yml`: * [ ] `docs/testing_instructions.rst` * [ ] `docs/usage.rst` -## Etc +## Follow-up issues -* [ ] Create follow-up issue with: - * [ ] Fine-tune CPU and mem limits (https://open.greenhost.net/stackspin/stackspin/-/ issues/1027) +Create follow-up issue with: + +* [ ] Fine-tune CPU and mem limits (https://open.greenhost.net/stackspin/stackspin/-/issues/1027) -- GitLab