Skip to content
Snippets Groups Projects

Resolve "Allow deletion of apps"

Merged Resolve "Allow deletion of apps"
129-allow-deletion-of-apps into main
1 unresolved thread
Merged Mart van Santen requested to merge 129-allow-deletion-of-apps into main
1 unresolved thread

Closes #129 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
backend/areas/apps/models.py
173 177 app_id=self.id
174 178 ).all()
175 179
180 @property
181 def oauthclients(self):
  • Arie Peterson
    Arie Peterson @arie ·
    Owner

    Although this works, it might be nicer to define oauthclients through a relationship, as the app and oauthclient_app tables have a foreign key relation. I think that makes it easier to understand what's going on. Note that that because this is a bi-directional relationship -- in the other direction we already define OAuthClientApp.app using relationship -- you have to use the back_populates argument to relationship.

    I just tried this locally, so if you want I can add it as a commit to this MR.

  • Mart van Santen
    Mart van Santen @mart ·
    Author Maintainer

    Please feel free to commit it. I am not very fluent in these models in python

  • Arie Peterson changed this line in version 4 of the diff

    changed this line in version 4 of the diff

  • Arie Peterson
    Arie Peterson @arie ·
    Owner

    Pushed. Please do verify that this still works the way you intended because I only did a very simple test :).

  • Please register or sign in to reply
  • Arie Peterson requested review from @mart and removed review request for @arie

    requested review from @mart and removed review request for @arie

  • Mart van Santen removed review request for @mart

    removed review request for @mart

  • Mart van Santen requested review from @arie

    requested review from @arie

  • Arie Peterson added 1 commit

    added 1 commit

    • d52dcb0a - Implement app.oauthclients using relationship

    Compare with previous version

  • Arie Peterson approved this merge request

    approved this merge request

  • Arie Peterson requested review from @mart and removed review request for @arie

    requested review from @mart and removed review request for @arie

  • Mart van Santen merged

    merged

  • Mart van Santen mentioned in commit 2650b98e

    mentioned in commit 2650b98e

    • Please register or sign in to reply