Resolve "Demo instance features"
Closes #117 (closed)
Merge request reports
Activity
changed milestone to %2.4
assigned to @arie
requested review from @syrine
- Resolved by Arie Peterson
The login feature works as expected and the code is pretty clear. I don't think there's a need for any additional comments.
I'm gonna complain about the UI though:
-
I think we could use some space between this button and the text below.
-
Are the quotes added intentionally? Maybe it's better if the text shows in a green banner like this?
-
Can the title
Sign up for this demo instance
be an<h3>
or<h4>
instead? It looks too big and not in harmony with the rest.
All this being said I'm definitely not a UI person but I reported the things that hurt my eyes
Edited by Syrine Neifar -
mentioned in commit 1ba07346