Merge branch '1112-setup-apps-sh-upgrades-pinned-apps-from-app-store' into 'main'

Resolve "setup-apps.sh upgrades pinned apps from app store"

Closes #1112

See merge request !576

CHANGELOG.md

 # Changelog
 
+## Unreleased
+
+* Keep app store disabled during setup script, to prevent apps from
+  unintentionally upgrading beyond their pinned versions.
+
 ## [0.15.21] - 2024-05-10
 
 * Allow setting SCIM token for use with the `scimserviceprovider` app.

Chart.yaml

@@ -4,7 +4,7 @@ description: |
   A helm chart for installing NextCloud and setting up ONLYOFFICE integration
 name: nextcloud-onlyoffice
 appVersion: NC-27.1.4-OO-7.2.2.56
-version: 0.15.21
+version: 0.15.22-appstore
 icon: https://cdn.rawgit.com/docker-library/docs/defa5ffc7123177acd60ddef6e16bddf694cc35f/nextcloud/logo.svg
 dependencies:
   # https://artifacthub.io/packages/helm/nextcloud/nextcloud

templates/nextcloud-onlyoffice-config.yaml

@@ -88,11 +88,6 @@ data:
 
     echo "Nextcloud is now installed, we can do our thing!"
 
-    # Enable app store so we can run `install` and `enable` commands
-    run_as "php $occ config:system:set appstoreenabled --type boolean --value true"
-
-    echo "app store enabled"
-
     app_versions=$(run_as "php $occ app:list --output json")
 
     echo "app versions found"
@@ -167,15 +162,9 @@ data:
     # them now
     run_as "php $occ upgrade"
 
-
     # Config settings from the configmap above
     run_as "php $occ config:import /var/local/config.json"
 
-    echo "disabling app store"
-
-    # Disable app store again
-    run_as "php $occ config:system:set appstoreenabled --type boolean --value false"
-
     echo "Updating database indices, columns, keys, etc."
     run_as "php $occ db:add-missing-indices --no-interaction"
     run_as "php $occ db:add-missing-columns --no-interaction"