WIP: Update hydra
Closes: #65 (closed)
Merge request reports
Activity
assigned to @mark
we can use the metadata field to store client metatdata in the oauth2client object.
In the oauth2clientobject, just add a field to metatdata. Maester will pick it up and save it to the hydra object. and hydra makes it available via the admin api.
root@single-sign-on-userbackend-6457d876fc-ggwmq:/# curl 10.43.169.219:4445/clients/nextcloud {"client_id":"nextcloud","client_name":"","redirect_uris":["https://files.open.alumnicloud.net/apps/sociallogin/custom_oidc/oas"],"grant_types":["authorization_code","refresh_token","client_credentials"],"response_types":["code","id_token"],"scope":"openid profile email openappstack_roles","audience":null,"owner":"nextcloud/oas","policy_uri":"","allowed_cors_origins":null,"tos_uri":"","client_uri":"","logo_uri":"","contacts":null,"client_secret_expires_at":0,"subject_type":"public","token_endpoint_auth_method":"client_secret_post","userinfo_signed_response_alg":"none","created_at":"0001-01-01T00:00:00Z","updated_at":"2021-03-24T11:58:06Z","metadata":{"client_name":"test"}so we now need to move
- Client uri to metdata
- display name to metadata
- logo_uri to metadata
But!
- I need to first check if the metadata object is also accessible via the python api
added 1 commit
- 85defd45 - temporarily set user-panel release to this branch
-
Blocked by https://github.com/ory/sdk/issues/65
-
I checked again if upgrading to the new single-sign-on release is possible if we use the old hydra client.
However as I pointed out in my comment above, we need to use the
metadatafield with maester. however the metadata field is not available with the old hydra client.See: https://github.com/westphahl/hydra-client/blob/master/src/hydra_client/oauth2.py
changed milestone to %0.7.0
changed milestone to %0.8.0
added 11 commits
-
f205e94b...b8d6e31a - 10 commits from branch
master - ec989e06 - Fix merge + conflicts
-
f205e94b...b8d6e31a - 10 commits from branch
added 1 commit
- 111006ce - tree is clean, no reason to reset branch, removed command
175 175 image: ${CI_REGISTRY_IMAGE}/pylint:${CI_COMMIT_REF_NAME} 176 176 script: 177 177 - echo "Reverting back to master to squash commits" 178 - pwd 179 - git status 180 - git pull 181 - git reset --soft master -
IIUC
git lintwould check the difference in pylint results from the source (master) to the current state of the git repo. I think this is why thisgit resetis here. If you remove this step, I don't thinkgit lintwould do anything.I propose we remove the whole job for now, because git-lint is deprecated
added 1 commit
- 15f4f1f9 - Move back to master version for consent formwq
added 1 commit
- f3711e27 - Useless change to see if it triggers a rebuilt
mentioned in issue #65 (closed)
@mart Can this MR get closed ?
