Skip to content
Snippets Groups Projects

Integration

Merged Mark requested to merge integration into master
All threads resolved!

Changes that needed to be made in order to integrate the user-panel into the single sign on environment

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Maarten de WaardMaarten de Waard 5 years ago (Nov 11, 2019 3:14pm UTC)

Merge details

  • Changes merged into master with 8867133d.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Maarten de Waard
  • Maarten de Waard
    • Resolved by Mark

      I'm assuming these scripts are meant as a temporary measure? Otherwise I would prefer to use something a bit more sophisticated than curl to do the requests. This runs the risk of mis-formatting the JSON because you're forwarding user input to the curl command directly

      Edited by Maarten de Waard
  • Maarten de Waard assigned to @mark and unassigned @maarten

    assigned to @mark and unassigned @maarten

  • Mark unassigned @mark

    unassigned @mark

  • assigned to @maarten

    • Resolved by Mark

      @mark I'd much prefer a version that uses a it more resilient language than (ba)sh, but is it true that you're already using this branch in other projects? Because in that case I'd say we merge this and make a new issue to port it to python.

      What do you think?

  • Maarten de Waard assigned to @mark and unassigned @maarten

    assigned to @mark and unassigned @maarten

  • Mark added 1 commit

    added 1 commit

    • 7d94b3f4 - Refactor and rename bash scripts

    Compare with previous version

  • I added a help output to the scripts and renamed them to '.bash' as bash features are used that are not supported by the shell. I also added the execution bit.

    I will also open an issue regarding the migration to python.

  • Mark assigned to @maarten and unassigned @mark

    assigned to @maarten and unassigned @mark

  • Mark mentioned in issue #17

    mentioned in issue #17

  • Maarten de Waard resolved all threads

    resolved all threads

  • Maarten de Waard
  • Maarten de Waard
  • Maarten de Waard assigned to @mark and unassigned @maarten

    assigned to @mark and unassigned @maarten

  • Mark added 1 commit

    added 1 commit

    Compare with previous version

  • Mark resolved all threads

    resolved all threads

  • Mark unassigned @mark

    unassigned @mark

  • assigned to @maarten

  • Mark added 1 commit

    added 1 commit

    Compare with previous version

  • mentioned in commit 8867133d

  • Please register or sign in to reply
    Loading