Move settings.yml to group_vars/all so pytest can use it

.gitlab-ci.yml

@@ -66,7 +66,7 @@ setup-openappstack:
     # Copy inventory files to ansible folder for use in install-apps step
     - chmod 700 ansible
     - cp clusters/${CI_COMMIT_REF_SLUG}/inventory.yml ansible/
-    - cp clusters/${CI_COMMIT_REF_SLUG}/settings.yml ansible/group_vars/all/
+    - cp clusters/${CI_COMMIT_REF_SLUG}/group_vars/all/settings.yml ansible/group_vars/all/
     # Set up cluster
     - python3 -m openappstack $HOSTNAME install
     # Show versions of installed apps/binaries

docs/troubleshooting.md

@@ -6,7 +6,7 @@ Note: `cluster$` indicates that the commands should be run as root on your OAS c
 
 If you encounter problems when you upgrade your cluster, please make sure first
 to include all potential new values of `ansible/group_vars/all/settings.yml.example`
-to your `clusters/YOUR_CLUSTERNAME/settings.yml`, and rerun the installation
+to your `clusters/YOUR_CLUSTERNAME/group_vars/all/settings.yml`, and rerun the installation
 script.
 
 
@@ -20,7 +20,7 @@ debug this:
 
 Did you create your cluster using the `--acme-staging` argument?
 Please check the resulting value of the `acme_staging` key in
-`clusters/YOUR_CLUSTERNAME/settings.yml`. If this is set to `true`, certificates
+`clusters/YOUR_CLUSTERNAME/group_vars/all/settings.yml`. If this is set to `true`, certificates
 are fetched from the [Let's Encrypt staging API](https://letsencrypt.org/docs/staging-environment/),
 which can't be validated by default in your browser.
 

openappstack/cluster.py

@@ -172,7 +172,8 @@ class Cluster:
     @property
     def settings_file(self):
         """Path to the ansible settings.yml for this cluster"""
-        return os.path.join(self.cluster_dir, 'settings.yml')
+        return os.path.join(self.cluster_dir, 'group_vars', 'all',
+                            'settings.yml')
 
     @property
     def behave_file(self):