Skip to content
Snippets Groups Projects
Verified Commit 5e5b8ce2 authored by Maarten de Waard's avatar Maarten de Waard :angel:
Browse files

raise exceptions instead of logging them and then failing relatively silently

parent 82478e50
No related branches found
No related tags found
No related merge requests found
......@@ -143,7 +143,7 @@ def store_kubernetes_secret(secret_dict, namespace, update=False):
)
except FailToCreateError as ex:
current_app.logger.info(f"Secret not created because of exception {ex}")
return
raise ex
current_app.logger.info(f"Secret {verb} with api response: {api_response}")
......@@ -172,7 +172,7 @@ def store_kustomization(kustomization_template_filepath, app_slug):
except FailToCreateError as ex:
current_app.logger.info(
f"Could not create {app_slug} Kustomization because of exception {ex}")
return False
raise ex
current_app.logger.debug(f"Kustomization created with api response: {api_response}")
return True
......@@ -202,7 +202,7 @@ def delete_kustomization(kustomization_name):
except ApiException as ex:
current_app.logger.info(
f"Could not delete {kustomization_name} Kustomization because of exception {ex}")
return False
raise ex
current_app.logger.debug(f"Kustomization deleted with api response: {api_response}")
return api_response
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment