Skip to content
Snippets Groups Projects
Commit 20564110 authored by Mart van Santen's avatar Mart van Santen
Browse files

Processed comments of review

parent 376f3623
No related branches found
No related tags found
1 merge request!100Resolve "Add logo for external services"
......@@ -174,14 +174,13 @@ export const UserModal = ({ open, onClose, userId, setUserId }: UserModalProps)
if (obj) {
return obj;
}
// Check if slug shows up in external list
let slug = item.name.toLowerCase();
// Strip ext from the slug, the ext prefix is advised in the documentation
// for external applications, however, we no not need it to match it with
// our application list
slug = slug.replace(/^ext-/, '');
slug = slug.replace(/^ext/, '');
obj = _.find(appExternalAccessList, ['name', slug!]);
if (obj) {
return obj;
......@@ -191,13 +190,13 @@ export const UserModal = ({ open, onClose, userId, setUserId }: UserModalProps)
return obj;
};
// Return logo of app, if not found, return a generic default
// Return filepath of logo of the app, if such logo file is specified
const fetchAppImage = (item: any) => {
const obj = fetchAppObject(item);
return obj?.image;
};
// Return name of app
// Return name/label of app
const fetchAppLabel = (item: any) => {
const obj = fetchAppObject(item);
if (obj?.label === '') {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment